https://bugs.kde.org/show_bug.cgi?id=375388

--- Comment #30 from somnia...@hushmail.com ---
(In reply to David Edmundson from comment #29)
> I have a theory on this.
> 
> The code is:
>     for (QQuickItem *childItem : qAsConst(childItems)) {
>         childVisibilityChanged |=
> QQuickItemPrivate::get(childItem)-
> >setEffectiveVisibleRecur(newEffectiveVisible);
>     }
>      ...
>     emit q->visibleChanged();
> 

Should it test for the current visible state before setting
newEffectiveVisible?

for (QQuickItem *childItem : qAsConst(childItems)) {
  if (childItem->isVisible() == newEffectiveVisible) continue;
  childVisibilityChanged |=
QQuickItemPrivate::get(childItem)->setEffectiveVisibleRecur(newEffectiveVisible);
}

And what happens if a childItem is disabled and its visibility is toggled?

if (!childItem->isEnabled || childItem->isVisible() == newEffectiveVisible)
continue;

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to