https://bugs.kde.org/show_bug.cgi?id=377298

Marco Martin <notm...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/pla
                   |                            |sma-workspace/bcb6b86d3ab8b
                   |                            |d196877473af343b72c53e4f932
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #4 from Marco Martin <notm...@gmail.com> ---
Git commit bcb6b86d3ab8bd196877473af343b72c53e4f932 by Marco Martin.
Committed on 10/03/2017 at 11:16.
Pushed by mart into branch 'Plasma/5.8'.

try proper order of corona()->availableScreenRect()

Summary:
connect to Plasma::Corona::availableScreenRectChanged
instead of using kscreen, this way we should be more sure
that signal is emitted when it's safe to call
corona()->availableScreenRect() as the change of rect
may happen after a screen removal, so may mean
accessing a desktop view while being deleted

Test Plan:
notifications still pop up in the proper place,
couldn't reproduce the crash neither before nor after tough

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4991

M  +3    -4    applets/notifications/lib/notificationsapplet.cpp
M  +1    -1    shell/shellcorona.cpp

https://commits.kde.org/plasma-workspace/bcb6b86d3ab8bd196877473af343b72c53e4f932

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to