https://bugs.kde.org/show_bug.cgi?id=376052
Jarosław Staniek <stan...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Latest Commit| |https://commits.kde.org/kdb
| |/46c6f293426de943319b74b8f3
| |98bb6803aa1a2d
Resolution|--- |FIXED
--- Comment #2 from Jarosław Staniek <stan...@kde.org> ---
Git commit 46c6f293426de943319b74b8f398bb6803aa1a2d by Jaroslaw Staniek.
Committed on 05/02/2017 at 23:31.
Pushed by staniek into branch 'master'.
Fix issues because of using " quotes for identifiers in SQLite driver
Use the [...] notation instead.
Details:
>From https://www.sqlite.org/lang_keywords.html:
RULE[*] "If a keyword in double quotes (ex: "key" or "glob") is used in a
context where it cannot be resolved to an identifier but where a string literal
is allowed, then the token is understood to be a string literal instead of an
identifier."
So for table T(A TEXT) this query works:
SELECT * FROM T WHERE "A1"='A1';
And it even returns all rows of T.
Expected: "identifier not found" error at SQLite level.
Notes: Kexi parses the KDbSQL query supplied by the user so there's no issue in
the Query Designer's SQL editor. But APIs such as KDb::deleteRecords() use the
native queries through calls such as KDbConnection::executeVoidSQL("DELETE FROM
%1 WHERE %2=%3").
Solution: Instead of using " quotes for identifiers, use []. This way the
RULE[*] will not be applied. This is a global solution for the SQLite driver so
altering the SQL commands constructed internally is not needed if they are use
KDbConnection::escapeIdentifier().
M +6 -4 src/KDbDriver.cpp
M +2 -1 src/KDbDriver.h
M +7 -2 src/KDbDriverBehavior.h
M +2 -1 src/KDbDriver_p.cpp
M +2 -1 src/drivers/mysql/MysqlDriver.cpp
M +2 -1 src/drivers/postgresql/PostgresqlDriver.cpp
M +2 -1 src/drivers/sqlite/SqliteDriver.cpp
M +2 -1 src/drivers/sybase/SybaseDriver.cpp
M +2 -1 src/drivers/xbase/XbaseDriver.cpp
https://commits.kde.org/kdb/46c6f293426de943319b74b8f398bb6803aa1a2d
--
You are receiving this mail because:
You are watching all bug changes.
