https://bugs.kde.org/show_bug.cgi?id=375610
David Faure <fa...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Status|UNCONFIRMED |CONFIRMED
--- Comment #2 from David Faure <fa...@kde.org> ---
Nice, thanks for the patch.
https://git.reviewboard.de.org is a better tool for getting patches reviewed
though.
I would like at least a comment that contains one of the lines that you show in
this bug report, so someone can understand (and possibly modify) the parsing
code even if the FTP site you mention no longer exists.
(yes we should have done that for the other cases too...)
The patch looks good otherwise (man we really should have some unittests for
this parsing code, to make sure changes don't break anything...).
--
You are receiving this mail because:
You are watching all bug changes.
