https://bugs.kde.org/show_bug.cgi?id=372309
Martin Koller <kol...@aon.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Latest Commit| |https://commits.kde.org/pla | |sma-desktop/1d05792ad782ce4 | |cd41e31c1ab6eef3026b5218b Resolution|--- |FIXED --- Comment #2 from Martin Koller <kol...@aon.at> --- Git commit 1d05792ad782ce4cd41e31c1ab6eef3026b5218b by Martin Koller. Committed on 29/01/2017 at 14:44. Pushed by mkoller into branch 'master'. Fix some bugs (mem leak, layout, preview not showing colors) 1) memory leak when opening SchemeEditorDialog (is never deleted) 2) The color preview widget can be reduced in height to nearly zero, which makes no sense 3) The scheme editor does not reflect any color change in the preview widget 4) triple-redundant widgets in the scmeditorcolors.ui file 5) user unfriendly current tab when opening the SchemeEditorDialog (I want to change a color, so the color tab shall be active) 6) Unneeded and incorrect tab index enum (enum values were not corresponding to the index the tab was inserted) 7) The SchemeEditorDialog did not just only expand the color table when enlarging the dialogs height Related: bug 372407 REVIEW: 129902 M +1 -0 kcms/colors/colorscm.cpp M +0 -6 kcms/colors/colorsettings.ui M +18 -18 kcms/colors/preview.ui M +1 -0 kcms/colors/scmeditorcolors.cpp M +5 -141 kcms/colors/scmeditorcolors.ui M +6 -5 kcms/colors/scmeditordialog.cpp M +0 -7 kcms/colors/scmeditordialog.h M +0 -12 kcms/colors/scmeditordialog.ui https://commits.kde.org/plasma-desktop/1d05792ad782ce4cd41e31c1ab6eef3026b5218b -- You are receiving this mail because: You are watching all bug changes.