https://bugs.kde.org/show_bug.cgi?id=375514
--- Comment #2 from Philippe Waroquiers <philippe.waroqui...@skynet.be> ---
IIUC, on mips, the test hgtls fails to properly show the static thread
variable:
static __thread int local;
I do not understand why we need this code on mips
but e.g. not on other platforms such as x86, amd64 or ppc.
Any idea ? If yes, it would be good to document why mips is special.
That being said, as this (mips only) code fixes the test hgtls, it looks good
to commit this.
Some small comments:
* As far as I can see, there is no (easy) way to modify auxprogs/getoff.c to
also generate the offset of tls_offset.
So, I would add a comment in the code, such as:
/* To check the assumption, start a gdb on none/tests/tls and do:
p &((struct link_map*)0x0)->l_tls_modid
p &((struct link_map*)0x0)->l_tls_offset */
* the function valgrind_get_tls_addr has a lot of dlog calls to indicate
which branch(es) it takes. It would be good to add a dlog (1, ...)
inside the 'if' to trace this branch is being taken.
Thanks for the analysis and patch.
(please modify NEWS also, when committing).
--
You are receiving this mail because:
You are watching all bug changes.
