https://bugs.kde.org/show_bug.cgi?id=512278

--- Comment #3 from Akseli Lahtinen <[email protected]> ---
Git commit 46950147e64cc1c36e7d4ca8e9ce7de0001bfaec by Akseli Lahtinen, on
behalf of Martin Sh.
Committed on 13/12/2025 at 20:13.
Pushed by akselmo into branch 'master'.

Various architectural improvements (in preparation for plasmoid work)

This MR doesn't change the behaviour of KomoDo (hopefully), but rather
addresses some architectural limitations, in preparation for adding a plasmoid.

I tried to keep the changelist clean and easy to follow, but here's a brief
list of what was changed anyway:
- Both the `ui` and `models` modules are now shared, instead of static.
- `TodoPage` has been moved from the `ui` module into the main executable (due
to having a lot of application-specific bits. The intention is to make the `ui`
module also usable by the plasmoid.)
- `TodoModel` is no longer a singleton.
- `TodoModel` and the configuration have been separated.
   - Configuration logic has been moved to the `komodo` executable, and it is
now done in the QML code.
   - A couple of `TodoModel` properties have been removed, since they were only
used for the config.
- A new method called `TodoModel.setLocalFilePath` has been added, which is
used when the user passes a `--filename` argument.
   - This solves a bug where the `--filename` argument didn't work.
- Changing `filePath` no longer calls `loadFile`, since this resulted in files
being loaded up to 3 times during initialization.

M  +8    -2    src/CMakeLists.txt
M  +1    -2    src/Main.qml
R  +58   -22   src/TodoPage.qml [from: src/ui/TodoPage.qml - 086% similarity]
M  +1    -2    src/autotests/CMakeLists.txt
R  +0    -0    src/komodo_config.kcfg [from: src/models/komodo_config.kcfg -
100% similarity]
M  +5    -0    src/main.cpp
M  +5    -5    src/models/CMakeLists.txt
M  +9    -44   src/models/TodoModel.cpp
M  +7    -13   src/models/TodoModel.h
M  +5    -5    src/ui/CMakeLists.txt

https://invent.kde.org/utilities/komodo/-/commit/46950147e64cc1c36e7d4ca8e9ce7de0001bfaec

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to