https://bugs.kde.org/show_bug.cgi?id=495261

--- Comment #40 from Igor Kushnir <[email protected]> ---
A MR is the way to go.

But I am not sure cherry-picking a single *recent* CMake commit into old
versions of copied files is safe. Updating to latest CMake code would be much
better as it would also fix other potential bugs and allow KDevelop to parse
CMake features introduced since the last synchronization in
https://commits.kde.org/kdevelop/f8dad839922dfc42ff89e8f5adea6d017c05b69b
(2017).

I have found two changes to KDevelop's CMake fork since that last
synchronization:
https://commits.kde.org/kdevelop/3fde9551d5870229d42cc1a61f152fc8d0876b71 and
https://commits.kde.org/kdevelop/6004c8fb46c31bd887015e397a3de29655fd06f9
The second commit essentially (unknowingly?) reverts the first, which suggests
that such small isolated fixes can cause other bugs and therefore may have to
be reverted.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to