https://bugs.kde.org/show_bug.cgi?id=451050

Sergey Katunin <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #96 from Sergey Katunin <[email protected]> ---
Looks like after
https://invent.kde.org/system/dolphin/-/commit/d0f8985b4c5c790781be6fcd06d299f087e78756
(https://invent.kde.org/system/dolphin/-/merge_requests/1036) this bug fixed in
Dolphin.

In that commit, `m_url` now is updated before `DolphinView::redirection`.

I'm talking about a crash after entering credentials (login and password) when
there is a connection to the root of the SMB server like `smb://server` or
`\\server` without specifying a trailing slash.

There was a problem when there were two redirects at the same time, one for
adding trailing slash, and second for appending username: 

1) `smb://server → smb://server/`

2) `smb://server/ → smb://user@server/`

This was reproduced with 100% chance before this commit, if you configure the
SMB server so that it requires a password when connecting to the root and
connect without trailing slash like `smb://server`.

It was crashed in KIO (`KCoreDirListerCache::slotUpdateResult`) because of
mismatch of URLs with an URL from the `itemsInUse` list.

Debug log before this commit (I output some extra info to log):

kf.kio.core: KCoreDirListerPrivate::redirect -  QUrl("smb://server")
QUrl("smb://server/")
kf.kio.core: slotUpdateResults:  QUrl("smb://user@server/")
kf.kio.core: itemsInUse:  QUrl("tags:/")
kf.kio.core: itemsInUse:  QUrl("smb://server/")
kf.kio.core: itemsInUse:  QUrl("trash:/")
kf.kio.core: Internal error: itemsInUse did not contain
QUrl("smb://user@server/")
KCrash: Application 'dolphin' crashing... crashRecursionCounter = 2

Debug log after this commit:

kf.kio.core: KCoreDirListerPrivate::redirect:  QUrl("smb://server")
QUrl("smb://server/")
kf.kio.core: KCoreDirListerPrivate::redirect:  QUrl("smb://server/")
QUrl("smb://user@server/")

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to