https://bugs.kde.org/show_bug.cgi?id=374904
Bug ID: 374904
Summary: Error cases of sub-jobs in MercurialPushJob and
MercurialAnnotateJob not handled properly
Product: kdevplatform
Version: git master
Platform: Other
OS: Linux
Status: UNCONFIRMED
Severity: minor
Priority: NOR
Component: mercurial
Assignee: kdevelop-bugs-n...@kde.org
Reporter: frank-fisc...@shadow-soft.de
Target Milestone: ---
The signals `readyForParsing` as well as `resultsReady` of a DVcsJob might only
be emitted if the process exits normally, i.e. if the process does not crash,
if it exits with code 0 or if it exits with some code != 0 and
DVcsJob::setIgnoreError(false) had been called (because of the implementation
of DVcsJob::slotProcessExited). However, the class MercurialPushJob only
connects to the signal `readyForParsing`, thus it may not recognize if one of
the sub-jobs crashed/fails.
I suggest to connect to the signal `KJob::finished` in all cases to catch
errors properly (and call MercurialPushJob::setFail() then).
I think the same problem exists in MercurialAnnotateJob.
--
You are receiving this mail because:
You are watching all bug changes.
