https://bugs.kde.org/show_bug.cgi?id=369783

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/pla
                   |                            |sma-desktop/4b46112a59cbd30
                   |                            |46f0682ef7dba3e12bfb13197
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #1 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 4b46112a59cbd3046f0682ef7dba3e12bfb13197 by David Edmundson.
Committed on 09/01/2017 at 14:00.
Pushed by davidedmundson into branch 'master'.

Return valid string value for DescriptionRole in all models

Summary:
A qml binding converting an empty QVariant to a string value will result
in a warning:
Unable to assign [undefined] to QString

Which is apparently happening to this bug reporter, but not for other
roles.

Grepping all models shows 2 code paths where this could happen.

Test Plan:
Kickoff/Kicker still open
Couldn't reproduce the original bug.

Reviewers: #plasma, hein

Reviewed By: #plasma, hein

Subscribers: hein, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4033

M  +2    -0    applets/kicker/plugin/computermodel.cpp
M  +2    -0    applets/kicker/plugin/recentcontactsmodel.cpp

https://commits.kde.org/plasma-desktop/4b46112a59cbd3046f0682ef7dba3e12bfb13197

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to