[Discover] [Bug 499260] Automatic shutdown/restart action closes apps without letting them prompt to save changes, potentially causing data loss

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=499260

--- Comment #8 from Nate Graham <n...@kde.org> ---
This diff in Discover fixes the issue:


diff --git discover/DiscoverObject.cpp discover/DiscoverObject.cpp
index 5623c21fe..f13aefa8b 100644
--- discover/DiscoverObject.cpp
+++ discover/DiscoverObject.cpp
@@ -670,12 +670,11 @@ void DiscoverObject::promptReboot()
 void DiscoverObject::rebootNow()
 {
     setAboutToReboot();
-    auto method =
QDBusMessage::createMethodCall(QStringLiteral("org.freedesktop.login1"),
-                                                
QStringLiteral("/org/freedesktop/login1"),
-                                                
QStringLiteral("org.freedesktop.login1.Manager"),
-                                                 QStringLiteral("Reboot"));
-    method.setArguments({true /*interactive*/});
-    QDBusConnection::systemBus().asyncCall(method);
+    auto method =
QDBusMessage::createMethodCall(QStringLiteral("org.kde.Shutdown"),
+                                                 QStringLiteral("/Shutdown"),
+                                                
QStringLiteral("org.kde.Shutdown"),
+                                                
QStringLiteral("logoutAndReboot"));
+    QDBusConnection::sessionBus().asyncCall(method);
 }


The question now is whether porting from org.freedesktop.login1 to
org.kde.Shutdown is the right approach, vs plumbing our session teardown code
and confirmation prompts through org.freedesktop.login1.

-- 
You are receiving this mail because:
You are watching all bug changes.