https://bugs.kde.org/show_bug.cgi?id=506928
--- Comment #1 from [email protected] --- Created attachment 183258 --> https://bugs.kde.org/attachment.cgi?id=183258&action=edit proposed patch (In reply to Mark Wielaard from comment #0) > Note that the struct ustat has two fields which differ on some architectures. > f_tfree is a long on sparc and mips, but an int on all others. > f_tinode is an unsigned int on alpha and s390, but unsigned long on all > others. After cross-compiling vmlinux and querying it with pahole, I can see that too \o/. Assuming sparc and alpha aren't actively supported by valgrind today, I've only handled this for mips and s390x. The first param of ustat is u32 in kernel. Which in practice should be equivalent to unsigned int. But to guarantee 32bits, I've included stdint.h and used uint32_t. I'm not sure if *flags |= SfMayBlock; should be used here. It's a disk operation so maybe it should (?) > char f_fname[6] and char f_fpack[6] are the same everywhere, but unused > (filled with zeros). How can this note be used in the valgrind source? --- Please, review the attached patch. -- You are receiving this mail because: You are watching all bug changes.
