https://bugs.kde.org/show_bug.cgi?id=374191
Simon <freisi...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #103144|0 |1
is obsolete| |
--- Comment #26 from Simon <freisi...@gmail.com> ---
Created attachment 103228
--> https://bugs.kde.org/attachment.cgi?id=103228&action=edit
Patch for triggering duplicates search for multiple tags with context menu and
refactor.
I took the sections of https://bugs.kde.org/attachment.cgi?id=103203 that are
relevant to this bug and extended the changes. My changes just extend the
refactoring, they don't introduce any change in behaviour:
- Use the new function selectedTagAlbums instead of selctedTags where
appropriate.
- Remove any remaining usages of ...FindDuplicatesInAlbum(Album*...
(albumselectiontreeview), such that everything related to duplicates sends
either PAlbums or TAlbums.
- Rename methods: s/Item/Album/. Items is usually used in the context of
indexes and other functions (currentAlbum) also use this terminology.
I played around with it and in album, tree and people view it worked as
expected. So from my side this is good to merge.
Regarding the similarity search of faces: I think the functionality as it is
currently is fine. Similarity search only on a face area would be more or less
the same as the recognize faces function, wouldn't it?
I absolutely agree that the people interface is still lacking in terms of
usability. It would be great having a way to separate confirmed from
unconfirmed faces. Then searching for similar face would work like: recognize
faces -> select a face tag -> only show unconfirmed faces
--
You are receiving this mail because:
You are watching all bug changes.
