https://bugs.kde.org/show_bug.cgi?id=501075

James Graham <james.h.gra...@protonmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/netw
                   |                            |ork/neochat/-/commit/dec536
                   |                            |9a8f01d1e6cf35aa600ade071eb
                   |                            |283941c

--- Comment #3 from James Graham <james.h.gra...@protonmail.com> ---
Git commit dec5369a8f01d1e6cf35aa600ade071eb283941c by James Graham.
Committed on 01/06/2025 at 09:37.
Pushed by nvrwhere into branch 'master'.

Actually position the view at the end

It turns out that for whatever reason ListView.posiitionViewAtEnd() ignores any
whitespace. This means that when we use the function it goes to the last
delegate. This is no good as we have some padding at the bottom to make space
for the typing indicator.

So the fix for this is stupid and involves adding a "spacer" delegate to the
timeline beginning model which is completely invisible but qml see as a
delegate so we can both leave the space and properly position the view at the
end.

M  +1    -0    src/timeline/CMakeLists.txt
M  +5    -0    src/timeline/EventDelegate.qml
A  +11   -0    src/timeline/SpacerDelegate.qml     [License: GPL(3+eV)
GPL(v3.0) GPL(v2.0)]
M  +0    -1    src/timeline/TimelineView.qml
M  +1    -0    src/timeline/enums/delegatetype.h
M  +4    -2    src/timeline/models/timelinemodel.cpp

https://invent.kde.org/network/neochat/-/commit/dec5369a8f01d1e6cf35aa600ade071eb283941c

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to