https://bugs.kde.org/show_bug.cgi?id=504956

Mark Wielaard <m...@klomp.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m...@klomp.org

--- Comment #1 from Mark Wielaard <m...@klomp.org> ---
Hi Martin,

(In reply to mcermak from comment #0)
> Created attachment 181860 [details]
> proposed patch
> 
> In some cases the LTP tests intentionally work with SIGSEGV.  This happens
> e.g. with the mmap18 and select03 testcases.  Valgrind detects SIGSEGV and
> reports that as a failure.
> 
> Such report can't be suppressed using the suppressions mechanism.  That's
> why this update comes with "output filters". Filters are scripts that read
> from their stdin, and write filtered output to their stdout. Filters reside
> in auxprogs/filters.
> 
> This update comes with 2 filters: For mmap18, and for select03.  They are
> awk scripts.

This looks really useful.

> Except for filters, this update also blacklists testcase fork13
> because it is slow.  It is possible to add comments prefixed with
> the '#' sign (implicitly - because they don't match any testcase
> name), and so a comment is added too.

Nice trick. We should comment the others too.

> This update also introduces new default valgrind arguments VGARGS.
> They are: --gen-suppressions=all and --vgdb=no.  The former is
> there for user convenience, so that a suppression can be easily
> captured and reused if needed. 

I am a little confused by this. Where do those suppressions appear and how/when
would you use them?

> The latter, --vgdb=no, improves
> valgrind behavior with nftw01 nftw6401 setfsgid04 setfsgid03_16
> and symlink03 testcases. These were previously complaining like
> this:
> 
> ==22969== could not unlink /tmp/vgdb-pipe-from-vgdb-to-22969-by-root-on ...

Aha. Yes, those testcases change uid during their runtime and so they no longer
own that file.
That seems OK. We aren't really testing the gdbserver functionality here.
Also these test must be run with privilege.

BTW. setfsgid04 doesn't seem to exist, did you mean setfsgid03?

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to