[frameworks-knewstuff] [Bug 503724] "Reviews and Comments" is styled as a web URL link, but navigates pages within the dialog

[Kristen McWilliam]

https://bugs.kde.org/show_bug.cgi?id=503724

Kristen McWilliam <kris...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/knewstuff/-/commit/e
                   |                            |833d3140aeaa40b19fd0043c93e
                   |                            |f5a51959c5ed
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from Kristen McWilliam <kris...@kde.org> ---
Git commit e833d3140aeaa40b19fd0043c93ef5a51959c5ed by Kristen McWilliam, on
behalf of John Veness.
Committed on 29/05/2025 at 13:06.
Pushed by merritt into branch 'master'.

Change "Comments and Reviews" link into a button

Right now this is a link but doesn't open a URL, violating the HIG
guideline against this. Instead, make it a conventional button.

With credit and many thanks to Nate Graham for his initial work on this (see
!363 for more discussion).

| Before | After |
| ------ | ------ |
| ![before](/uploads/1b1ad8590cb31280e71699c24e79bcfb/before.png) |
![3](/uploads/def779c05653473bc7938ca301112472/3.png) |
| ![before_narrow](/uploads/ff7173f5d099e1c51339e7f7dcb2b75e/before_narrow.png)
| ![3_narrow](/uploads/ef37cbabe396d840bcfef18b3e18170e/3_narrow.png) |

M  +8    -7    src/qtquick/qml/EntryDetails.qml

https://invent.kde.org/frameworks/knewstuff/-/commit/e833d3140aeaa40b19fd0043c93ef5a51959c5ed

-- 
You are receiving this mail because:
You are watching all bug changes.