https://bugs.kde.org/show_bug.cgi?id=503813

--- Comment #34 from Igor Kushnir <igor...@gmail.com> ---
(In reply to ulterno from comment #33)
> > Do you mean that both the Menu key AND a version-controlled document are 
> > required?
> 
> Yes, it is the "AND".
> However, it even works if the "version-controlled document" is gitignored
> and even if the .git repo has just been inited with nothing staged (refer
> STEP 0 of REPRODUCTION)
If GitPlugin::isValidDirectory() called from
DistributedVersionControlPlugin::contextMenuExtension() returns false,
additionalMenuEntries() is never invoked.

> Just in case you are wondering, adding a return at the point giving the
> error, does not prevent the crash (or the frozen GUI before it).
That's because d->cleanContextMenu() schedules destruction of the previous
menu, so the QPointer guards are necessary to prevent the crash.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to