https://bugs.kde.org/show_bug.cgi?id=502679
--- Comment #9 from Mark Wielaard <m...@klomp.org> ---
Hi Martin,
(In reply to mcermak from comment #8)
> Hi Mark. Thank you for your thorough review! I've attempted to address
> your concerns one by one. Please check the attached patch. Does it look
> good to you now?
Currently testing with these changes:
diff --git a/auxprogs/Makefile.am b/auxprogs/Makefile.am
index 27c22857ede6..00c743bc11f8 100644
--- a/auxprogs/Makefile.am
+++ b/auxprogs/Makefile.am
@@ -229,7 +229,9 @@ gsl-check: $(GSL_BUILD_DIR)/gsl-build
$(GSL_BUILD_DIR)/valgrind-gsl.out
ltp-check: $(LTP_SRC_DIR)
- LTP_SRC_DIR=$(LTP_SRC_DIR) $(abs_top_srcdir)/auxprogs/ltp-tester.sh
+ LTP_SRC_DIR=$(LTP_SRC_DIR) \
+ VALGRIND=$(abs_top_builddir)/vg-in-place \
+ $(abs_top_srcdir)/auxprogs/ltp-tester.sh
# We keep the tarball but remove the unpacked sources and build
diff --git a/auxprogs/ltp-tester.sh b/auxprogs/ltp-tester.sh
index 45a968801757..a3c2157c56d7 100755
--- a/auxprogs/ltp-tester.sh
+++ b/auxprogs/ltp-tester.sh
@@ -26,7 +26,7 @@ myLog ()
cd $LTP_SRC_DIR
-mapfile -t files < <(find testcases/kernel/syscalls -executable -and -type f |
sort | head -10)
+mapfile -t files < <(find testcases/kernel/syscalls -executable -and -type f |
sort)
c=${#files[@]}; i=0
for test in "${files[@]}"; do
@@ -55,7 +55,7 @@ for test in "${files[@]}"; do
# Check logs, report errors
pushd $l >/dev/null
- if test $(wc -l log2 | cut -d' ' -f1) -gt 0; then
+ if test -s log2; then
myLog "${exe}: unempty log2:\n$(cat log2)"
fi
--
You are receiving this mail because:
You are watching all bug changes.
