https://bugs.kde.org/show_bug.cgi?id=423669

Luke Horwell <c...@horwell.me> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |c...@horwell.me

--- Comment #13 from Luke Horwell <c...@horwell.me> ---
For years, since switching from MATE (GNOME 2) to KDE, I've patched my copy of
`plasma-integration` with this command:

    sed -i 's/QDialogButtonBox::KdeLayout/QDialogButtonBox::GnomeLayout/g'
{qt5,qt6}/src/platformtheme/khintssettings.cpp

I agree with the UX point of view that primary actions are better / more
optimum on the right - due to eyes scanning in a zig-zag pattern. However, it
is also a good point that KDE for the longest time declared [in Qt] the primary
button being first (like Windows), so transition could be more involved. For
the most part, Qt Widgets and GTK apps were consistent on my system, but I just
realised in this report Qt Quick (e.g. configuring an applet) was not
[OK/Apply/Cancel].

Like with the "single click" and "double click" default, I think having an
option in System Settings to choose would be good to start with, since it is
currently hardcoded. There is a secret plan for KDE world domination, right? :)

I should note that since Plasma 6, KFileWidget is hardcoding the button order
[OK, Cancel] in `src/filewidgets/kfilewidget.cpp`. (It probably should be using
a QDialogButtonBox)

```
--- a/src/filewidgets/kfilewidget.cpp
+++ b/src/filewidgets/kfilewidget.cpp   
@@ -1473,8 +1473,8 @@
                             
q->style()->pixelMetric(QStyle::PM_LayoutBottomMargin));

     hbox->addStretch(2);
-    hbox->addWidget(m_okButton);
     hbox->addWidget(m_cancelButton);
+    hbox->addWidget(m_okButton);

     m_opsWidgetLayout->addLayout(hbox);
 ```

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to