https://bugs.kde.org/show_bug.cgi?id=488896
Arjen Hiemstra <ahiems...@heimr.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Latest Commit| |https://invent.kde.org/plas
| |ma/kpipewire/-/commit/52911
| |b7060fc3341c4ab4b308be1e47f
| |985e8576
Resolution|--- |FIXED
--- Comment #24 from Arjen Hiemstra <ahiems...@heimr.nl> ---
Git commit 52911b7060fc3341c4ab4b308be1e47f985e8576 by Arjen Hiemstra.
Committed on 21/03/2025 at 09:44.
Pushed by ahiemstra into branch 'master'.
Change Encoder::applyEncodingPreference() to buildEncodingOptions()
As it turns out, FFmpeg does something to the pointers here that causes
the dictionary to never be properly used. This means we were never
applying the encoding options, as avcodec_open() was passed a nullptr
for options.
Fix this by changing the function to return an AVDictionary* instead of
trying to modify a passed-in pointer. This results in a proper dict
being returned, that can then be passed to avcodec_open().
The main result of this is that we now properly apply the encoding
options for VP9 encoding, which means we can now encode VP9 at realtime
speeds instead of it massively lagging behind.
M +5 -1 src/encoder.cpp
M +1 -1 src/encoder_p.h
M +0 -7 src/gifencoder.cpp
M +0 -1 src/gifencoder_p.h
M +5 -5 src/h264vaapiencoder.cpp
M +1 -1 src/h264vaapiencoder_p.h
M +5 -5 src/libopenh264encoder.cpp
M +1 -1 src/libopenh264encoder_p.h
M +6 -4 src/libvpxencoder.cpp
M +1 -1 src/libvpxencoder_p.h
M +6 -4 src/libvpxvp9encoder.cpp
M +1 -1 src/libvpxvp9encoder_p.h
M +0 -1 src/libwebpencoder_p.h
M +6 -5 src/libx264encoder.cpp
M +1 -1 src/libx264encoder_p.h
https://invent.kde.org/plasma/kpipewire/-/commit/52911b7060fc3341c4ab4b308be1e47f985e8576
--
You are receiving this mail because:
You are watching all bug changes.
