https://bugs.kde.org/show_bug.cgi?id=497931

mclan...@proton.me changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mclan...@proton.me

--- Comment #4 from mclan...@proton.me ---
I've looked into this and on my machine the crash happens because it thinks the
file has mime type image/x-panasonic-rw, and then it decides to read in the
rest of the file.

If you make it so that the extension in the filename isn't the tiebreaker, it
correctly determines the mime type to be application/octet-stream, and this
problem is fixed. It looks like it has been done before in this merge request,
https://invent.kde.org/graphics/gwenview/-/merge_requests/60 but it was
reverted because it broke reading some types of raw image files, see:
https://bugs.kde.org/show_bug.cgi?id=441698

I have two different ideas on how to fix this, but I'm not an expert on mime
types so someone can let me know if either of them will work without breaking
things. My first idea is that we do the same thing as in the above merge
request, but only if the filename ends with .raw. I assume this will work fine
if every mime type that can have filenames ending with .raw can be correctly
determined by its data. 

My other idea is to determine the mime type again based on only the data if it
thinks the mime type is image/x-panasonic-rw, and use the new mime type from
data if it is different. I don't think this could break anything, but I don't
know if the .raw extension is guaranteed to be seen as image/x-panasonic-rw, so
if it could be different on somebody else's machine then this bug won't really
be fixed.

Bonus bug: If you "open with gwenview" the raw file from dolphin, gwenview will
crash for the same reason as this

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to