https://bugs.kde.org/show_bug.cgi?id=501194
Bug ID: 501194
Summary: Fix ML_(check_macho_and_get_rw_loads) so that it is
correct for any number of segment commands
Classification: Developer tools
Product: valgrind
Version: 3.24 GIT
Platform: Compiled Sources
OS: macOS
Status: REPORTED
Severity: normal
Priority: NOR
Component: general
Assignee: jsew...@acm.org
Reporter: pjfl...@wanadoo.fr
Target Milestone: ---
Currently this function gets passed a fixed size (4k) buffer. That might not be
big enough for all segment commands.
This needs to be changed so that it gets passed 'actual_fd'. Then inside
ML_(check_macho_and_get_rw_loads) it should
- open the file
- allocate a buffer on the heap of size struct MACH_HEADER
- read the header
- realloc the buf with size struct MACH_HEADER + header->sizeofcmds
- process as previously
- free the buffer
- close the file
--
You are receiving this mail because:
You are watching all bug changes.
