https://bugs.kde.org/show_bug.cgi?id=486949

--- Comment #13 from Igor Kushnir <igor...@gmail.com> ---
Git commit 737fd44d385acd2d1e174601a226968ba57fd4e0 by Igor Kushnir.
Committed on 06/03/2025 at 10:17.
Pushed by igorkushnir into branch 'master'.

Make connections to the signal repositoryBranchChanged() unique

The slots ProjectChangesModel::addProject(),
RepoStatusModel::addProject() and VcsOverlayProxyModel::addProject() are
invoked for each opened project. If an opened project's version control
plugin is the GitPlugin, each of these 3 slots connects the
corresponding class's repositoryBranchChanged() slot to the namesake
signal of GitPlugin. As the connections are not unique, the number of
invocations of each class's repositoryBranchChanged() slot is multiplied
by the number of opened git projects.

Use the function pointer-based connection syntax in
RepoStatusModel::addProject(). The string-based connection and the
accompanying comment have been thoughtlessly copied from a place where
`plugin` is an IPlugin* rather than a GitPlugin*.

M  +2    -1    kdevplatform/project/projectchangesmodel.cpp
M  +2    -2    plugins/git/repostatusmodel.cpp
M  +2    -1    plugins/projectmanagerview/vcsoverlayproxymodel.cpp

https://invent.kde.org/kdevelop/kdevelop/-/commit/737fd44d385acd2d1e174601a226968ba57fd4e0

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to