https://bugs.kde.org/show_bug.cgi?id=427288

--- Comment #6 from Igor Kushnir <igor...@gmail.com> ---
Git commit 8eba5d57ae037ac2df96844731a1c3c3f93d7cde by Igor Kushnir.
Committed on 10/02/2025 at 14:30.
Pushed by igorkushnir into branch 'master'.

sublime: force tool view grouping only if the button is Ctrl-clicked

Before 38fa47e9860da2c3c3deb9f4312fa5a4bd343e56 and the commit(s) fixed
by it, only Ctrl-clicking a tool view button forced tool view grouping.
After that commit, the tool view grouping occurs whenever a Ctrl key is
held down while a tool view action becomes checked. This forced grouping
is wrong in the following scenarios:
1. If the user assigns a shortcut containing a Ctrl key to a tool view,
   triggering the shortcut while the tool view is hidden groups the tool
   view with other already shown tool views in its dock widget area.
2. The default shortcuts for the actions "Previous Tool View" and
   "Next Tool View" contain the Ctrl key. Therefore, triggering these
   shortcuts groups the previous/next tool view with already shown
   one(s) in the same dock widget area instead of replacing them.
3. Holding the Ctrl key when a tool view is raised programmatically
   prevents hiding already visible tool views in the same dock widget
   area.

The third scenario could be considered a well-hidden feature: when the
user expects a tool view to be raised, [s]he can hold the Ctrl key to
show it alongside already visible ones. This questionable feature could
be used as a crude workaround for Bug 427288. But fixing behavior in the
other two scenarios is more important than preserving the workaround.

Let IdealToolButton track its pressed-down state and force tool view
grouping only if checking the tool view action is triggered by
Ctrl-clicking the associated tool view button.

M  +8    -2    kdevplatform/sublime/idealbuttonbarwidget.cpp
M  +12   -0    kdevplatform/sublime/idealtoolbutton.cpp
M  +9    -0    kdevplatform/sublime/idealtoolbutton.h

https://invent.kde.org/kdevelop/kdevelop/-/commit/8eba5d57ae037ac2df96844731a1c3c3f93d7cde

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to