https://bugs.kde.org/show_bug.cgi?id=445321

Igor Kushnir <igor...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Version Fixed In|                            |6.2.250400
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/kdev
                   |                            |elop/kdevelop/-/commit/9959
                   |                            |6f83b5d18428a8a60ecba3ee080
                   |                            |31c480bcc

--- Comment #2 from Igor Kushnir <igor...@gmail.com> ---
Git commit 99596f83b5d18428a8a60ecba3ee08031c480bcc by Igor Kushnir.
Committed on 10/02/2025 at 14:30.
Pushed by igorkushnir into branch 'master'.

sublime: don't remove the DockWidgetFloatable feature

IdealDockWidget() calls `setFeatures(QDockWidget::DockWidgetClosable |
    QDockWidget::DockWidgetMovable | QDockWidget::DockWidgetFloatable)`.
IdealButtonBarWidget::addWidget() adds the DockWidgetVerticalTitleBar
feature to a dock widget in the bottom or the top dock widget area.
IdealController::dockLocationChanged() sets the same area-dependent dock
features except for DockWidgetFloatable. This bug was introduced in
fb1a0e4464a17eb6207257f23d6ae1fdb67def83, which added the
DockWidgetFloatable feature in IdealDockWidget() but a duplicate
DockWidgetMovable feature in IdealController::dockLocationChanged().
ea30a3e957830a7c861bac7475d5aba50ebc8716 then removed the duplicate
feature from dockLocationChanged().

IdealController::dockLocationChanged() already calls
IdealButtonBarWidget::addWidget(). So remove the
DockWidgetVerticalTitleBar feature if not needed in addWidget() instead
of repeating the always enabled feature set in dockLocationChanged().
FIXED-IN: 6.2.250400

M  +7    -2    kdevplatform/sublime/idealbuttonbarwidget.cpp
M  +0    -5    kdevplatform/sublime/idealcontroller.cpp

https://invent.kde.org/kdevelop/kdevelop/-/commit/99596f83b5d18428a8a60ecba3ee08031c480bcc

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to