https://bugs.kde.org/show_bug.cgi?id=448833

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
                   |ma/plasma-workspace/-/commi |ma/plasma-workspace/-/commi
                   |t/bbe6ff3cffa567f7c4bc568fb |t/8f8e48bb6e09e4859d0430f11
                   |a5d89dc445a153a             |b340f4dcac8b734

--- Comment #55 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 8f8e48bb6e09e4859d0430f11b340f4dcac8b734 by David Edmundson, on
behalf of David Edmundson.
Committed on 06/02/2025 at 15:15.
Pushed by davidedmundson into branch 'Plasma/6.3'.

klipper: Avoid breaking Listview

A listview by default will keep the highlight in view, scrolling the
list appropriately. This is not desired in Klipper where putting the
mouse over a clipped final delegate should not move the index.

A complicated fix was added in 31a547cc by trying to tweak at what point
we change the current index.

This is extremely messy especially when coupled with delegates of
changing heights. We start changing the current item which we know will
trigger a scroll which changes the current item. ListView gets confused
and it's not surprising.

There's a considerably simpler fix for the original bug, don't use
ListView highlights if we don't want ListView behaviour.

This fixes overlapping delegates in Klipper.


(cherry picked from commit bbe6ff3cffa567f7c4bc568fba5d89dc445a153a)

Co-authored-by: David Edmundson <k...@davidedmundson.co.uk>

(cherry picked from commit 939c1a368a28fc162815bfd7e4861876945e8e00)

Co-authored-by: David Edmundson <da...@davidedmundson.co.uk>

M  +12   -10   klipper/declarative/qml/ClipboardItemDelegate.qml
M  +1    -3    klipper/declarative/qml/ClipboardMenu.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/8f8e48bb6e09e4859d0430f11b340f4dcac8b734

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to