https://bugs.kde.org/show_bug.cgi?id=486949

--- Comment #11 from Igor Kushnir <igor...@gmail.com> ---
(In reply to Igor Kushnir from comment #9)
> A more complicated issue is that RepoStatusModel and ProjectChangesModel
> both run `git status` with the same parameters when something changes.
> Ideally, their code should be deduplicated and refactored so that `git
> status` is run only once. But that's much more difficult, especially because
> the Project Changes tool view seems utterly broken and would require a lot
> of work to fix.
The relevant duplicated code in RepoStatusModel and ProjectChangesModel is
broken in many ways. ProjectChangesModel is almost completely nonfunctional
(otherwise, KDevelop would freeze unbearably!), so I am tempted to mostly
remove or at least disable it.

Since many KDevelop users don't use the Git Commit tool view, they should not
pay the price for its poor performance in the background. So I would like to
make RepoStatusModel, along with the Git Commit tool view that uses it,
optional and off by default. Perhaps moving m_repoStatusModel from GitPlugin to
CommitToolView would work? This way, the slow RepoStatusModel would exist only
as long as the Git Commit tool view is present, and then we could display some
kind of poor-background-performance warning for the Git Commit tool view.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to