https://bugs.kde.org/show_bug.cgi?id=497245
Vlad Zahorodnii <vlad.zahorod...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Latest Commit| |https://invent.kde.org/plas
| |ma/kwin/-/commit/3eb29f1849
| |c74bd59f0778f14aa58efc7ec24
| |c99
Resolution|--- |FIXED
--- Comment #11 from Vlad Zahorodnii <vlad.zahorod...@kde.org> ---
Git commit 3eb29f1849c74bd59f0778f14aa58efc7ec24c99 by Vlad Zahorodnii.
Committed on 16/01/2025 at 15:06.
Pushed by vladz into branch 'master'.
Prevent including global shortcut keys in wl_keyboard.enter
78bc268876343a313fcb2e7346985371e030ee71 moved pressed key tracking to
a higher abstraction layer. It made pressed keys tracking less error
prone but it also uncovered that the old code used not to update pressed
keys in certain situations, e.g. when pressing a shortcut, but it's
possible that there are more cases.
With global shortcuts, the following can occur
- press Meta
- press Space
- focused keyboard surface changes, it has "Space" in the enter event
- release Space, it will be sent to the new focused surface
- release Meta
Depending on the implementation details, the client can register the
Space key getting pressed and released.
Another event sequence that can cause unexpected behavior is
- press q
- the client sees it and closes its surface
- focused keyboard surface changes, it has "q" in the enter event
- release q
The root cause is the lack of key stroke ownership. It's not expressed
in any possible way. We need to do it in long term, as a more short
term solution, this change adds filtered keys property. If a particular
event filter thinks that the clients should not see particular key, they
just add that key to that list. After the key is released, it will be
removed from the list.
M +1 -0 autotests/integration/CMakeLists.txt
A +303 -0 autotests/integration/keyboard_input_test.cpp [License:
GPL(v2.0+)]
M +11 -0 autotests/integration/kwin_wayland_test.h
M +62 -16 autotests/integration/test_helpers.cpp
M +4 -1 src/input.cpp
M +26 -1 src/keyboard_input.cpp
M +12 -0 src/keyboard_input.h
M +1 -1 src/popup_input_filter.cpp
https://invent.kde.org/plasma/kwin/-/commit/3eb29f1849c74bd59f0778f14aa58efc7ec24c99
--
You are receiving this mail because:
You are watching all bug changes.
