https://bugs.kde.org/show_bug.cgi?id=497136
Bug ID: 497136 Summary: Kleopatra doesn't build on macOS due to not having Wayland Classification: Applications Product: kleopatra Version: 4.0.0.241190 Platform: Homebrew (macOS) OS: macOS Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: kloec...@kde.org Reporter: le...@unshare.net CC: aheine...@gnupg.org, kdepim-b...@kde.org, m...@kde.org Target Milestone: --- SUMMARY Kleopatra has Wayland specific code guarded by `#ifdef Q_OS_UNIX`, which also matches macOS. That's why `#include <KWaylandExtras>` is attempted, but such a header doesn't exist on macOS build. A different kind of guard is required. A similar solution has been found in KIO. See: https://invent.kde.org/frameworks/kio/-/blob/c36a98157c7ece4ccaf784b3346460acfac94ccc/CMakeLists.txt#L129 The fix is proposed. MR: https://invent.kde.org/pim/kleopatra/-/merge_requests/334 Commit: https://invent.kde.org/pim/kleopatra/-/commit/3d7308a7f38a70ab161d6acf621131461a4bb2be STEPS TO REPRODUCE 1. Setup Homebrew (macOS) environment, all the Kleopatra dependencies are accounted for. 2. Checkout v24.11.90 tag from Kleopatra repository. 2. Do `cmake -S . -B build --install-prefix <prefix>` 3. Do `cmake --build build` OBSERVED RESULT Build fails due to missing `KWaylandExtras` header. EXPECTED RESULT Build completes. SOFTWARE/OS VERSIONS macOS: 15.1 KDE Frameworks Version: 6.8.0 (built from sources myself) Qt Version: 6.7.3 (Homebrew, from bottle) ADDITIONAL INFORMATION The proposed fix is already well tested. -- You are receiving this mail because: You are watching all bug changes.