https://bugs.kde.org/show_bug.cgi?id=355919
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |k...@davidedmundson.co.uk
--- Comment #3 from David Edmundson <k...@davidedmundson.co.uk> ---
Thanks
Sorry it's taken me so long to see your patches. It's pretty poor on my side.
http://git.reviewboard.kde.org is the better place for patches, they stay at
the top of my TODO list better.
Code-wise your patches seem fine:
- make findImageTransparentBounding const
- fix typo in comment
- + painter.drawImage((ximage.width() - ximage.height())/2, 0,
ximage);
should be height - width
Though I don't like how potentially slow it's going to be if we have an icon in
the tray animating at 60fps
We *should* be resizing the window when we get it (see line ~160).
Before merging this, I'd like to see why the resize hasn't worked. Are we just
grabbing the image too early? Does the client change itself back?
--
You are receiving this mail because:
You are watching all bug changes.
