https://bugs.kde.org/show_bug.cgi?id=222392

--- Comment #33 from Elvis Angelaccio <elvis.angelac...@kdemail.net> ---
Git commit d059701e0a07bc8214e6e0a4104732d09c05cf35 by Elvis Angelaccio.
Committed on 08/12/2015 at 21:09.
Pushed by elvisangelaccio into branch 'Applications/15.12'.

Do not show a messagebox with empty error message

When the user stops an AddToArchive job (e.g. from the Notifications plasmoid),
the errorText() of the stopped AddJob is empty and a meaningless KMessageBox is
displayed. With this patch, the messagebox is created only if there is an error
to show.

As a side effect, Ark stops crashing when using cliplugins, because
emitResult() is not
blocked anymore by the messagebox. For the same reason, the end of the
cliplugin's
QProcess is not anymore delayed until the user closes the messagebox.

Note that if there would be an error message, Ark would crash anyway.

M  +2    -2    kerfuffle/addtoarchive.cpp

http://commits.kde.org/ark/d059701e0a07bc8214e6e0a4104732d09c05cf35

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to