https://bugs.kde.org/show_bug.cgi?id=355069
Martin Klapetek <mklape...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |http://commits.kde.org/plas
| |ma-workspace/4a6f7db0018a2a
| |7366ac7f2ad61fc33f31566c03
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Version Fixed In| |5.5.0
--- Comment #3 from Martin Klapetek <mklape...@kde.org> ---
Git commit 4a6f7db0018a2a7366ac7f2ad61fc33f31566c03 by Martin Klapetek.
Committed on 03/12/2015 at 04:10.
Pushed by mklapetek into branch 'Plasma/5.5'.
[notifications] Rework the notifications positioning a bit
The notifications popup positioning recently regressed
by some other changes (looks like Qt) and the popups
would fly across the screen.
The proper solution is using KWin effect but given how
close the release is, this needs to be dealt with in a
different way.
The main problem is calculating the initial popup size
because as long as the Dialog is invisible, it has an
incorrect geometry, so it needs to be positioned right
after it's being displayed. The Dialog however gets the
sizes even later, so the code now calls a slot from Dialog
that ensures the sizes are correct before the initial
placement on screen. It's not ideal but I'm out of ideas
otherwise. Plus it should be only temporary until the
KWin effect will replace it.
Besides that, it moves the custom position handling from the
QML into the C++ applet class, making it easier.
REVIEW: 126221
FIXED-IN: 5.5.0
M +28 -3 applets/notifications/lib/notificationsapplet.cpp
M +4 -1 applets/notifications/lib/notificationsapplet.h
M +1 -19 applets/notifications/package/contents/ui/Notifications.qml
M +49 -8 applets/notifications/plugin/notificationshelper.cpp
M +2 -0 applets/notifications/plugin/notificationshelper.h
http://commits.kde.org/plasma-workspace/4a6f7db0018a2a7366ac7f2ad61fc33f31566c03
--
You are receiving this mail because:
You are watching all bug changes.
