On Tue, 16 Apr 2024 00:31:10 GMT, Leonid Mesnik <[email protected]> wrote:
>> Kevin Walls has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits since the last revision:
>>
>> - Remove System.exit calls
>> - Merge remote-tracking branch 'upstream/master' into
>> 8188784_BroadcasterSupportDeadlockTest
>> - 8188784:
>> javax/management/notification/BroadcasterSupportDeadlockTest.java - TEST
>> FAILED: deadlock
>
> test/jdk/javax/management/notification/BroadcasterSupportDeadlockTest.java
> line 122:
>
>> 120: java.util.Map<Thread,StackTraceElement[]> traces =
>> Thread.getAllStackTraces();
>> 121: showStackTrace("Thread 1", traces.get(t1));
>> 122: showStackTrace("Thread 2", traces.get(t2));
>
> Could you please replace System.exit() with throwing Exception. Other looks
> good.
OK sure.
FYI I count 137 System.exit calls in test/jdk/javax/management
That's after I take out the existing 3 that are in this test. 8-)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18687#discussion_r1567098465
