On Mon, 5 Feb 2024 16:53:33 GMT, Magnus Ihse Bursie <[email protected]> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Restore period > > src/jdk.management.agent/share/classes/jdk/internal/agent/resources/agent_ko.properties > line 27: > >> 25: >> 26: agent.err.error = 오류 >> 27: agent.err.exception = 에이전트에 예외사항이 발생했습니다. > > I decided to remove the period here... I think it should probably stay, but this is really guess work. Would be nice to have a locale expert weigh in on this one. The reason I think it should stay is because it is a period at the end of a sentence vs a single word. Looking at some of the English entries sheds some light one this fact: agent.err.error = Error agent.err.exception = Exception thrown by the agent agent.err.warning = Warning agent.err.configfile.notfound = Config file not found agent.err.configfile.failed = Failed in reading the config file agent.err.configfile.closed.failed = Failed in closing the config file agent.err.configfile.access.denied = Access to the config file is denied Within this group, the error and warning entries are the only ones without a period (in the Korean version) and the only ones that are a single word instead of a sentence. However, I'm not sure why any of them have the period in the first place since the English version does not. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/11490#discussion_r1478829597
