Author: sebb
Date: Wed Nov 5 08:40:50 2008
New Revision: 711607
URL: http://svn.apache.org/viewvc?rev=711607&view=rev
Log:
Make field final; replace local constants with ones from Short class
Modified:
jakarta/jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/TCPClientDecorator.java
Modified:
jakarta/jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/TCPClientDecorator.java
URL:
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/TCPClientDecorator.java?rev=711607&r1=711606&r2=711607&view=diff
==============================================================================
---
jakarta/jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/TCPClientDecorator.java
(original)
+++
jakarta/jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/TCPClientDecorator.java
Wed Nov 5 08:40:50 2008
@@ -17,17 +17,15 @@
*/
/*
- * TCP Sampler Client decorator to permit wrapping base client implementations
with length prefixes.
+ * TCP Sampler Client decorator to permit wrapping base client implementations
with length prefixes.
+ * For example, character data or binary data with character length or binary
length
*
*/
package org.apache.jmeter.protocol.tcp.sampler;
public abstract class TCPClientDecorator implements TCPClient {
- public static final int SHORT_MAX_VALUE = 32767;
-
- public static final int SHORT_MIN_VALUE = -32768;
-
- protected TCPClient tcpClient;
+
+ protected final TCPClient tcpClient; // the data implementation
public TCPClientDecorator(TCPClient tcpClient) {
this.tcpClient = tcpClient;
@@ -44,7 +42,7 @@
*/
public static byte[] intToByteArray(int value, int len) {
if (len == 2 || len == 4) {
- if (len == 2 && (value < SHORT_MIN_VALUE || value >
SHORT_MAX_VALUE)) {
+ if (len == 2 && (value < Short.MIN_VALUE || value >
Short.MAX_VALUE)) {
throw new IllegalArgumentException("Value outside range for
signed short int.");
} else {
byte[] b = new byte[len];
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
