Author: sebb
Date: Wed Mar 19 19:56:47 2008
New Revision: 639123
URL: http://svn.apache.org/viewvc?rev=639123&view=rev
Log:
BuilderFactory may not be thread-safe
Modified:
jakarta/jmeter/trunk/src/core/org/apache/jmeter/util/XPathUtil.java
Modified: jakarta/jmeter/trunk/src/core/org/apache/jmeter/util/XPathUtil.java
URL:
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/util/XPathUtil.java?rev=639123&r1=639122&r2=639123&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/core/org/apache/jmeter/util/XPathUtil.java
(original)
+++ jakarta/jmeter/trunk/src/core/org/apache/jmeter/util/XPathUtil.java Wed Mar
19 19:56:47 2008
@@ -80,8 +80,10 @@
* @return document builder
* @throws ParserConfigurationException
*/
- public static DocumentBuilder makeDocumentBuilder(boolean validate,
boolean whitespace, boolean namespace)
+ public static synchronized DocumentBuilder makeDocumentBuilder(boolean
validate, boolean whitespace, boolean namespace)
throws ParserConfigurationException {
+ // N.B. the factory is re-usable, but not necessarily thread-safe,
so
+ // the method is synchronized to protect the creation of the builder
DocumentBuilder builder = makeDocumentBuilderFactory(validate,
whitespace, namespace).newDocumentBuilder();
builder.setErrorHandler(new MyErrorHandler(validate, false));
return builder;
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
