cmccabe commented on code in PR #12031:
URL: https://github.com/apache/kafka/pull/12031#discussion_r848910920
##########
metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAcl.java:
##########
@@ -96,6 +97,13 @@ public String principal() {
return principal;
}
+ public KafkaPrincipal kafkaPrincipal() {
Review Comment:
What happens here when there is no colon? I guess type becomes the empty
string and name becomes everything?
Should we set type = `User` instead, or throw an exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
