dongjinleekr commented on a change in pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#discussion_r830011584
##########
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStoreTest.java
##########
@@ -53,161 +53,166 @@ RocksDBStore getRocksDBStore() {
@Test
public void shouldOpenNewStoreInRegularMode() {
- try (final LogCaptureAppender appender =
LogCaptureAppender.createAndRegister(RocksDBTimestampedStore.class)) {
+ try (final LogCaptureContext logCaptureContext =
LogCaptureContext.create()) {
+ logCaptureContext.setLatch(2);
rocksDBStore.init((StateStoreContext) context, rocksDBStore);
- assertThat(appender.getMessages(), hasItem("Opening store " +
DB_NAME + " in regular mode"));
- }
+ assertThat(logCaptureContext.getMessages(), hasItem("INFO Opening
store " + DB_NAME + " in regular mode "));
- try (final KeyValueIterator<Bytes, byte[]> iterator =
rocksDBStore.all()) {
- assertThat(iterator.hasNext(), is(false));
+ try (final KeyValueIterator<Bytes, byte[]> iterator =
rocksDBStore.all()) {
+ assertThat(iterator.hasNext(), is(false));
+ }
}
}
@Test
public void shouldOpenExistingStoreInRegularMode() throws Exception {
- // prepare store
- rocksDBStore.init((StateStoreContext) context, rocksDBStore);
- rocksDBStore.put(new Bytes("key".getBytes()),
"timestamped".getBytes());
- rocksDBStore.close();
+ try (final LogCaptureContext logCaptureContext =
LogCaptureContext.create()) {
+ logCaptureContext.setLatch(3);
- // re-open store
- try (final LogCaptureAppender appender =
LogCaptureAppender.createAndRegister(RocksDBTimestampedStore.class)) {
+ // prepare store
rocksDBStore.init((StateStoreContext) context, rocksDBStore);
-
- assertThat(appender.getMessages(), hasItem("Opening store " +
DB_NAME + " in regular mode"));
- } finally {
+ rocksDBStore.put(new Bytes("key".getBytes()),
"timestamped".getBytes());
rocksDBStore.close();
Review comment:
The try block with `LogCaptureAppender` resource was removed; That's the
reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
