ableegoldman commented on a change in pull request #11857:
URL: https://github.com/apache/kafka/pull/11857#discussion_r821099068
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##########
@@ -84,14 +84,14 @@
public AtomicLong topologyVersion = new AtomicLong(0L); // the local
topology version
public ReentrantLock topologyLock = new ReentrantLock();
public Condition topologyCV = topologyLock.newCondition();
- public List<TopologyVersionWaiters> activeTopologyWaiters = new
LinkedList<>();
+ public List<TopologyVersionListener> activeTopologyUpdateListeners =
new LinkedList<>();
Review comment:
Oh right actually no, we. do still need it to be an AtomicLong as we
check it in the StreamThread main loop when looking for topology updates. And
obviously we don't want to have to grab the full lock for that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
