ableegoldman opened a new pull request #11857: URL: https://github.com/apache/kafka/pull/11857
We used to call `TopologyMetadata#maybeNotifyTopologyVersionWaitersAndUpdateThreadsTopologyVersion` when a thread was being unregistered/shutting down, to check if any of the futures listening for topology updates had been waiting on this thread and could be completed. Prior to invoking this we make sure to remove the current thread from the TopologyMetadata's `threadVersions` map, but this thread is actually then re-added in the `#maybeNotifyTopologyVersionWaitersAndUpdateThreadsTopologyVersion` call. To fix this, we should break up this method into separate calls for each of its two distinct functions, updating the version and checking for topology update completion. When unregistering a thread, we should only invoke the latter method -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
