vvcephei commented on a change in pull request #11624:
URL: https://github.com/apache/kafka/pull/11624#discussion_r774098877
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java
##########
@@ -365,109 +395,200 @@ public void beforeTest() {
final Properties streamsConfig = streamsConfiguration(
cache,
log,
- storeToTest.name()
+ storeToTest.name(),
+ kind
);
final StreamsBuilder builder = new StreamsBuilder();
- if (supplier instanceof KeyValueBytesStoreSupplier) {
- final Materialized<Integer, Integer, KeyValueStore<Bytes, byte[]>>
materialized =
- Materialized.as((KeyValueBytesStoreSupplier) supplier);
+ if (Objects.equals(kind, "DSL") && supplier instanceof
KeyValueBytesStoreSupplier) {
+ setUpKeyValueDSLTopology((KeyValueBytesStoreSupplier) supplier,
builder);
Review comment:
This method was already too long to comfortably read. Doubling its
length by adding PAPI was out of the question, so I extracted some methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
