showuon commented on a change in pull request #11195:
URL: https://github.com/apache/kafka/pull/11195#discussion_r685830975
##########
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSplitTest.java
##########
@@ -104,40 +105,45 @@ public void testResultingMap() {
// "foo-bar"
.branch(isEven, Branched.as("bar"))
// no entry: a Consumer is provided
- .branch(isMultipleOfThree, Branched.withConsumer(ks ->
{
- }))
+ .branch(isMultipleOfThree, Branched.withConsumer(ks ->
{ }))
// no entry: chain function returns null
.branch(isMultipleOfFive, Branched.withFunction(ks ->
null))
- // "foo-4": name defaults to the branch position
+ // "foo-4": chain function returns non-null value
+ .branch(isNegative, Branched.withFunction(ks -> ks))
+ // "foo-5": name defaults to the branch position
.branch(isMultipleOfSeven)
Review comment:
add a test case for function return with non-null result case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
