cmccabe commented on a change in pull request #10946:
URL: https://github.com/apache/kafka/pull/10946#discussion_r662599796
##########
File path: metadata/src/test/java/org/apache/kafka/metalog/LocalLogManager.java
##########
@@ -198,7 +207,12 @@ synchronized void unregisterLogManager(LocalLogManager
logManager) {
}
}
- synchronized long tryAppend(int nodeId, long epoch, LocalBatch batch) {
+ synchronized long tryAppend(int nodeId, int epoch,
List<ApiMessageAndVersion> batch) {
+ // No easy access to the concept of time. Use the base offset as
the append timestamp
Review comment:
Can you multiply the offset by 10 or something so that the numbers for
time are slightly different than those for offset? That would help ensure we're
not getting them mixed up elsewhere in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
