[GitHub] [kafka] mjsax commented on a change in pull request #10813: KAFKA-9559: Change default serde to be `null`

[GitBox]

mjsax commented on a change in pull request #10813:
URL: https://github.com/apache/kafka/pull/10813#discussion_r661897674



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/state/internals/LeftOrRightValueDeserializer.java
##########
@@ -35,17 +36,17 @@ public LeftOrRightValueDeserializer(final Deserializer<V1> 
leftDeserializer, fin
 
     @SuppressWarnings("unchecked")
     @Override
-    public void setIfUnset(final Deserializer<Void> defaultKeyDeserializer, 
final Deserializer<Object> defaultValueDeserializer) {
+    public void setIfUnset(final SerdeGetter getter) {
         if (leftDeserializer == null) {
-            leftDeserializer = (Deserializer<V1>) 
Objects.requireNonNull(defaultValueDeserializer, "defaultValueDeserializer 
cannot be null");
+            leftDeserializer = (Deserializer<V1>) 
Objects.requireNonNull(getter.valueSerde().deserializer(), 
"defaultValueDeserializer cannot be null");

Review comment:
       as above. `requireNotNull` not necessary any longer

##########
File path: 
streams/src/main/java/org/apache/kafka/streams/state/internals/LeftOrRightValueDeserializer.java
##########
@@ -35,17 +36,17 @@ public LeftOrRightValueDeserializer(final Deserializer<V1> 
leftDeserializer, fin
 
     @SuppressWarnings("unchecked")
     @Override
-    public void setIfUnset(final Deserializer<Void> defaultKeyDeserializer, 
final Deserializer<Object> defaultValueDeserializer) {
+    public void setIfUnset(final SerdeGetter getter) {
         if (leftDeserializer == null) {
-            leftDeserializer = (Deserializer<V1>) 
Objects.requireNonNull(defaultValueDeserializer, "defaultValueDeserializer 
cannot be null");
+            leftDeserializer = (Deserializer<V1>) 
Objects.requireNonNull(getter.valueSerde().deserializer(), 
"defaultValueDeserializer cannot be null");
         }
 
         if (rightDeserializer == null) {
-            rightDeserializer = (Deserializer<V2>) 
Objects.requireNonNull(defaultValueDeserializer, "defaultValueDeserializer 
cannot be null");
+            rightDeserializer = (Deserializer<V2>) 
Objects.requireNonNull(getter.valueSerde().deserializer(), 
"defaultValueDeserializer cannot be null");

Review comment:
       as above. `requireNotNull` not necessary any longer

##########
File path: 
streams/src/main/java/org/apache/kafka/streams/state/internals/LeftOrRightValueSerializer.java
##########
@@ -40,17 +41,17 @@ public LeftOrRightValueSerializer(final Serializer<V1> 
leftSerializer, final Ser
 
     @SuppressWarnings("unchecked")
     @Override
-    public void setIfUnset(final Serializer<Void> defaultKeySerializer, final 
Serializer<Object> defaultValueSerializer) {
+    public void setIfUnset(final SerdeGetter getter) {
         if (leftSerializer == null) {
-            leftSerializer = (Serializer<V1>) 
Objects.requireNonNull(defaultValueSerializer, "defaultValueSerializer cannot 
be null");
+            leftSerializer = (Serializer<V1>) 
Objects.requireNonNull(getter.valueSerde().serializer(), 
"defaultValueSerializer cannot be null");

Review comment:
       as above

##########
File path: 
streams/src/main/java/org/apache/kafka/streams/state/internals/LeftOrRightValueSerializer.java
##########
@@ -40,17 +41,17 @@ public LeftOrRightValueSerializer(final Serializer<V1> 
leftSerializer, final Ser
 
     @SuppressWarnings("unchecked")
     @Override
-    public void setIfUnset(final Serializer<Void> defaultKeySerializer, final 
Serializer<Object> defaultValueSerializer) {
+    public void setIfUnset(final SerdeGetter getter) {
         if (leftSerializer == null) {
-            leftSerializer = (Serializer<V1>) 
Objects.requireNonNull(defaultValueSerializer, "defaultValueSerializer cannot 
be null");
+            leftSerializer = (Serializer<V1>) 
Objects.requireNonNull(getter.valueSerde().serializer(), 
"defaultValueSerializer cannot be null");
         }
 
         if (rightSerializer == null) {
-            rightSerializer = (Serializer<V2>) 
Objects.requireNonNull(defaultValueSerializer, "defaultValueSerializer cannot 
be null");
+            rightSerializer = (Serializer<V2>) 
Objects.requireNonNull(getter.valueSerde().serializer(), 
"defaultValueSerializer cannot be null");

Review comment:
       as above




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org