cadonna opened a new pull request #9286:
URL: https://github.com/apache/kafka/pull/9286


   The test StreamsBrokerBounceTest.test_all_brokers_bounce() fails on
   2.5 because in the last stage of the test there is only one broker
   left and the offset commit cannot succeed because the
   min.insync.replicas of __consumer_offsets is set to 2 and acks is
   set to all. This causes a time out and extends the closing of the
   Kafka Streams client to beyond the duration passed to the close
   method of the client.
   
   This affects especially the 2.5 branch since there Kafka Streams
   commits offsets for each task, i.e., close() needs to wait for the
   timeout for each task. In 2.6 and trunk the offset commit is done
   per thread, so close() does only need to wait for one time out per
   stream thread.
   
   I opened this PR on trunk, since the test could also become
   flaky on trunk and we want to avoid diverging system tests across
   branches.
   
   A more complete solution would be to improve the test by defining
   a better success criteria.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to