nileshkumar3 commented on PR #21665: URL: https://github.com/apache/kafka/pull/21665#issuecomment-4063096032
KAFKA-13630 is scoped to ready() and drain(), and I don’t see a safe way to reduce the lock scope further in those paths. In drain(), trunk already performs the heavier work (e.g., batch.close()) outside the deque lock while keeping the txn/idempotent bookkeeping inside the critical section. In ready(), the locking also already appears minimal after KAFKA-16226. Given that, this PR does not appear to introduce a safe improvement over the current implementation. I’m closing the PR for now. If there is a specific remaining hotspot in ready() or drain() worth addressing, we can revisit with a targeted change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
