akhileshchg commented on code in PR #21654:
URL: https://github.com/apache/kafka/pull/21654#discussion_r2898464056
##########
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##########
@@ -1192,8 +1207,15 @@ static void modifyInterBrokerThrottle(Admin adminClient,
Set<Integer> reassigningBrokers,
long interBrokerThrottle) throws
ExecutionException, InterruptedException {
if (interBrokerThrottle >= 0) {
+ Set<Integer> liveBrokers = getLiveBrokerIds(adminClient);
+ Set<Integer> brokersToUpdate = reassigningBrokers.stream()
+ .filter(liveBrokers::contains)
Review Comment:
The live broker set is fetched at one point in time, but the
incrementalAlterConfigs call happens later. A broker could go down between
these two calls, or come back up. This is inherent to the approach and probably
acceptable, but worth acknowledging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
