clolov commented on code in PR #21627:
URL: https://github.com/apache/kafka/pull/21627#discussion_r2896110652
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -93,6 +113,10 @@ public final class GroupConfig extends AbstractConfig {
public final String shareAutoOffsetReset;
+ public final int shareAssignmentIntervalMs;
+
+ public final Optional<Boolean> shareAssignorOffloadEnable;
Review Comment:
Sorry, let me try to explain what I meant in a different way. You have 3
pairs of new configurations which can be set on both the group coordinator
level and on the group level.
Here is a similar example for another configuration
group.consumer.session.timeout.ms (group coordinator level
https://kafka.apache.org/42/configuration/broker-configs/#brokerconfigs_group.consumer.session.timeout.ms)
and consumer.session.timeout.ms (group level
https://kafka.apache.org/42/configuration/group-configs/#groupconfigs_consumer.session.timeout.ms).
Instead of deciding to use -1 at the group level to fall through to the
group coordinator level, the definition at the group level is:
```
...
.define(CONSUMER_SESSION_TIMEOUT_MS_CONFIG,
INT,
GroupCoordinatorConfig.CONSUMER_GROUP_SESSION_TIMEOUT_MS_DEFAULT, <-- We
reference the default to be the group coordinator level default
atLeast(1),
MEDIUM,
GroupCoordinatorConfig.CONSUMER_GROUP_SESSION_TIMEOUT_MS_DOC)
...
```
Do you reckon we can do something similar here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
