[
https://issues.apache.org/jira/browse/KAFKA-20248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18062583#comment-18062583
]
sanghyeok An commented on KAFKA-20248:
--------------------------------------
[~mjsax]
Apologies for the confusion!
My original intent was to ensure that any fields missing between the Streams
Protocol client and server are included in the client request.
While working on something else, I quickly checked {{instanceId}} and
{{{}rackId{}}}, but I haven’t yet investigated whether any other fields are
missing.
I wasn’t aware that {{rackId}} could be addressed under KAFKA-20116.
If {{instanceId}} is handled in KAFKA-20169 and {{rackId}} is handled in
KAFKA-20116, then the fields I understood to be currently unhandled would all
be covered, so it seems reasonable to close this ticket.
Another option would be to repurpose this ticket by updating its title and
scope to something like: “Investigate fields that are mentioned in the KIP but
are not actually used in practice.”
That said, I’m concerned that keeping this ticket open could create confusion
alongside other ongoing KIP-1071-related work.
For that reason, my default preference would be to close it. Which option would
you prefer?
> Support fields that are not yet supported in StreamsGroup.
> ----------------------------------------------------------
>
> Key: KAFKA-20248
> URL: https://issues.apache.org/jira/browse/KAFKA-20248
> Project: Kafka
> Issue Type: Task
> Components: clients, streams
> Reporter: sanghyeok An
> Assignee: sanghyeok An
> Priority: Minor
> Labels: kip1071
>
> According to KIP-1071, the StreamsGroup protocol is required to support
> various fields. However, at the client level, this is not fully implemented
> yet.
> For example, as you can see in this code, KIP-1071 specifies that fields such
> as {{rackId}} should be set when present, but they are not currently included
> in the client request. {{rackId}} is an important factor in determining the
> group epoch in the Streams protocol.
> (https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java#L295-L310)
> Although these fields are explicitly defined in the KIP-1071 document, they
> are not yet included in the actual client request. The goal of this ticket is
> to support such fields that are defined in KIP-1071 but are still missing
> from the client request.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
